Alex/kaido-core
SHA256
Watch
1
0
Fork
You've already forked kaido-core
 0
Code Issues 10 Pull requests 1 Releases Activity Actions

Remove process references from code #78

Merged
Alex merged 3 commits from 76-remove-process-references into main 2026-11-08 13:22:09 +01:00
Conversation 2 Commits 3 Files changed 24 +72 -75
Alex commented 2026-11-06 21:29:01 +01:00
Owner

Problem

  • Code referred to ADR numbers, work packages, waves, reviews and PoC phases (#76).

Change

  • Removed these references from comments, test names and SQL.
  • Renamed six *_review_test.go files, wp26Manager and TestIsolatedGatewayReview*.
  • Dropped a stale comment about a row map in history_tables.go.
  • Kept as product terms: commit review, wave mode in deploy-config.sh. Kept *_audit_regression_test.go, where audit names product types such as DraftAudit.

Validation

  • go vet on the nine changed packages on the builder VM: passed.

🤖 Generated with Claude Code

## Problem - Code referred to ADR numbers, work packages, waves, reviews and PoC phases (#76). ## Change - Removed these references from comments, test names and SQL. - Renamed six `*_review_test.go` files, `wp26Manager` and `TestIsolatedGatewayReview*`. - Dropped a stale comment about a row map in `history_tables.go`. - Kept as product terms: commit review, wave mode in `deploy-config.sh`. Kept `*_audit_regression_test.go`, where audit names product types such as `DraftAudit`. ## Validation - `go vet` on the nine changed packages on the builder VM: passed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) 
Comments, test names and SQL no longer point to ADR numbers, work
packages, waves, reviews or proof-of-concept phases. Test files and
helpers named after a review or work package now describe their content.

Refs #76

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #76

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kaido-reviewer approved these changes 2026-11-08 13:20:39 +01:00
Dismissed
kaido-reviewer left a comment

Reviewed revision

  • PR #78, head 7326192d444d82a9a74b37fccfcaf0eec07c62e153bdad56b8c89e1561ce33be
  • Diff against merge base 128d7799d738859fcff554ee56b7740b1f2814135d49343e196f3d92508efab9: 24 files, 6 of them renames

Checks

  • Behaviour: the non-comment changes are limited to file renames, test and helper identifiers (groupReviewLab to groupLab, wp26Manager to firewallSavingManager, TestIsolatedGatewayReview* to TestIsolatedGatewayGroup*), and test fixture literals (group name GROUP, UDP payload probe-packet). The payload is only echoed and its content or length is not asserted.
  • Tests: 3514 test functions at base and at head. The function-symbol comparison shows only the intended renames. No assertion was removed or weakened.
  • References: no remaining reference to the old file names, identifiers or test names anywhere in the tree, including Makefiles and scripts. The new identifiers do not collide with existing symbols. New file names carry no GOOS/GOARCH suffix, and each matches the tests it contains.
  • Remaining process references: none found in Go, SQL, shell or UI code for ADR numbers, work packages, waves, reviews or proof-of-concept phases. Remaining matches are product or technical terms: draft/commit review, the Wave 1 deploy stage in scripts/deploy/deploy-config.sh, IPsec phases, and the two-stage history diff.
  • Comments: the reworded comments are still accurate and none became empty, including the cross-reference in restore_databases_test.go and the factory-firewall seed comment.

Findings

  • No substantive findings.

Validation limits

  • Static review only. No tests, builds, go vet or browser sessions were run by the reviewer.
## Reviewed revision - PR #78, head `7326192d444d82a9a74b37fccfcaf0eec07c62e153bdad56b8c89e1561ce33be` - Diff against merge base `128d7799d738859fcff554ee56b7740b1f2814135d49343e196f3d92508efab9`: 24 files, 6 of them renames ## Checks - **Behaviour:** the non-comment changes are limited to file renames, test and helper identifiers (`groupReviewLab` to `groupLab`, `wp26Manager` to `firewallSavingManager`, `TestIsolatedGatewayReview*` to `TestIsolatedGatewayGroup*`), and test fixture literals (group name `GROUP`, UDP payload `probe-packet`). The payload is only echoed and its content or length is not asserted. - **Tests:** 3514 test functions at base and at head. The function-symbol comparison shows only the intended renames. No assertion was removed or weakened. - **References:** no remaining reference to the old file names, identifiers or test names anywhere in the tree, including Makefiles and scripts. The new identifiers do not collide with existing symbols. New file names carry no GOOS/GOARCH suffix, and each matches the tests it contains. - **Remaining process references:** none found in Go, SQL, shell or UI code for ADR numbers, work packages, waves, reviews or proof-of-concept phases. Remaining matches are product or technical terms: draft/commit review, the `Wave 1` deploy stage in `scripts/deploy/deploy-config.sh`, IPsec phases, and the two-stage history diff. - **Comments:** the reworded comments are still accurate and none became empty, including the cross-reference in `restore_databases_test.go` and the factory-firewall seed comment. ## Findings - No substantive findings. ## Validation limits - Static review only. No tests, builds, `go vet` or browser sessions were run by the reviewer. 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kaido-reviewer approved these changes 2026-11-08 13:21:54 +01:00
kaido-reviewer left a comment

Static review of revision 6d412c68e1

Static review only: no tests, builds or checks were run by the reviewer.

Scope

  • Synchronization merge on top of previously reviewed revision 7326192d (review id 40).

Verification

  • Parents are 7326192d (PR branch) and 9a379c68 (main).
  • git diff 7326192d 6d412c68 --stat lists only tests/e2e/rauc_ab/scenarios.py (11 insertions, 3 deletions).
  • That diff has the same patch id as main's commit 9a379c68, the only commit between the merge base 128d7799 and 9a379c68.
  • git diff 9a379c68 6d412c68 is identical to git diff 128d7799 7326192d (24 files, 72 insertions, 75 deletions), in file list and content.
  • git show --remerge-diff of the merge is empty: no conflict resolution altered the content.

Findings

  • None.
## Static review of revision 6d412c68e13e2b2cfe20d0fbf3e20f7282f9040a Static review only: no tests, builds or checks were run by the reviewer. ## Scope - Synchronization merge on top of previously reviewed revision 7326192d (review id 40). ## Verification - Parents are 7326192d (PR branch) and 9a379c68 (main). - `git diff 7326192d 6d412c68 --stat` lists only `tests/e2e/rauc_ab/scenarios.py` (11 insertions, 3 deletions). - That diff has the same patch id as main's commit 9a379c68, the only commit between the merge base 128d7799 and 9a379c68. - `git diff 9a379c68 6d412c68` is identical to `git diff 128d7799 7326192d` (24 files, 72 insertions, 75 deletions), in file list and content. - `git show --remerge-diff` of the merge is empty: no conflict resolution altered the content. ## Findings - None.
Alex merged commit 244becaf6e into main 2026-11-08 13:22:09 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
kaido-reviewer
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Alex/kaido-core!78
No description provided.