Remove legacy DHCP/DNS conversion and recover stopped restore sources #27
No reviewers
Labels
No labels
No milestone
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Alex/kaido-core!27
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/25-remove-legacy-dhcp-dns"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
DHCP/DNS storage, restore and candidate loading now preserve configured RouterState values without automatic legacy conversion. Removes obsolete converter/history migration and mutating schema upgrade behavior; native runtime prerequisites are checked before database initialization. During beta, fresh installations are assumed and no compatibility or rejection path is introduced.
Includes the scoped recovery changes from PR #29: pending restore can inspect a stopped native lease store despite stale HA addresses, and an exactly empty stopped allocator source can receive truthful retirement proof without fabricated factory provenance. Native capture safety checks and nonempty-source refusal remain in place. Regression tests cover the reported failures and guard boundaries.
Closes #25. Partially addresses #28; do not close #28. English/German configuration-history guides and API references were updated locally in kaido-docs and remain uncommitted as required.
Validation
Final combined source:
b5975f128a305fea919386e4b3150977058a50842f3a1916e511fc5096f98530, based on main05f7e29(including PR #30). Fullmake checkpassed: Go race tests, vet, 325 UI tests, and Svelte zero errors/warnings. Combinedmake check-buildpassed. Independent static review of implementation, regression tests, integration, scripts and existing evidence found no substantive findings.Scope7, Minis-Forum and RZ-VM run the exact final source binary, SHA256
ea904ab327cb16077d888faefa33b23aee1df71e4bf9279695a04be27f254d77. API readiness, full configuration equality and no pending transaction passed on each. Authorized SQLite purge/backup restore completed on all three. Scope7 cold reboot restored management automatically; RZ restored and rebooted successfully. Minis-Forum required an agent restart after link readiness; that remaining startup problem is documented in #28. Final binary updates preserved configuration without another purge or native-service stop.Staticcheck 2026.2.1 was executed separately: exit 1, 108 existing diagnostics versus 112 on clean main, zero new diagnostics. The Makefile's optional lint probe skipped staticcheck because the task-private tool was outside PATH; the explicit run and baseline comparison supply its actual result. The user explicitly accepted this inherited-check exception and authorized merge. Follow-up tracking: #31. Broader availability findings remain deferred in #28, which must stay open.
[WIP] Remove automatic legacy DHCP/DNS conversionto Remove legacy DHCP/DNS conversion and recover stopped restore sourcesIndependent static review complete for head
498ac17df5. Its Git tree exactly matches reviewed and testedb5975f1(8428042aeb). No substantive in-scope findings. Reviewed regression sources, full check/build evidence, and exact final binary/configuration/API validation on all three reserved routers. Staticcheck exits 1 with 108 inherited diagnostics, zero new versus main; the user explicitly accepted this exception, tracked in #31. Broader startup availability work remains open in #28. Reviewer performed source/evidence inspection only and executed no tests, builds, or device actions.